Passing a literal null to an Optional parameter is almost certainly a mistake. Did you mean to provide an empty Optional?


The problem

Passing a literal null to an Optional accepting parameter is likely a bug. Optional is already designed to encode missing values through a non-null instance.

Optional<Integer> double(Optional<Integer> i) {
  return -> i * 2);

Optional<Integer> doubled = double(null);
Optional<Integer> doubled = double(Optional.empty());

This is a scenario that can easily happen when refactoring code from accepting @Nullable parameters to accept Optionals. Note that the check will not match if the parameter is explicitly annotated @Nullable.


Suppress false positives by adding the suppression annotation @SuppressWarnings("NullOptional") to the enclosing element.